⚠️ No Changeset found

Latest commit: 7eb1909

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@delucis can close this PR? Looks like the update is going to be fine

@delucis can close this PR? Looks like the update is going to be fine

I’m not sure we know that yet. There’s a lot of changes to how e.g. peer deps work in v2 — we’d probably need to test more to be sure. But if the draft PR is annoying us, we can still close it if you prefer. I’m also not sure what the timeline for v2 is, it’s been a while since any new alpha releases went out.

Yeah I was trying to clean the open PRs a bit but it's not the end of the world. If you want, you could add the PR or a draft item to https://github.com/orgs/withastro/projects/21 so we remember to look at it for v6

The refactor in #15006 seems to not like unstorage v2 — we get type errors here for each driver:

https://github.com/withastro/astro/blob/0702bdb300ba9599e657c7c144a7273bcccb0b57/packages/astro/src/core/session/drivers.ts#L32

Example error:

Exported variable 'sessionDrivers' has or is using name 'AzureAppConfigurationOptions' from external module "astro/node_modules/.pnpm/unstorage@2.0.0-alpha.5_@azure+identity@4.13.0_@netlify+blobs@10.5.0_@vercel+functions@_80d853d842f68f127967aed5609fbb80/node_modules/unstorage/dist/index" but cannot be named.

Merging this PR will not alter performance

✅ 18 untouched benchmarks

_{Comparing chris/unstorage-v2 (7eb1909) with main (ed2b536)}